yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: sahara
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1300265

Title:
  some tests call assert_called_once() into a mock, this function
  doesn't exists, and gets auto-mocked, falsely passing tests

Status in neutron:
  Fix Released
Status in Sahara:
  Fix Released
Status in Sahara kilo series:
  Fix Committed

Bug description:
  neutron/tests/unit/agent/linux/test_async_process.py:        spawn.assert_called_once()
  neutron/tests/unit/agent/linux/test_async_process.py:            func.assert_called_once()
  neutron/tests/unit/agent/linux/test_async_process.py:        mock_start.assert_called_once()
  neutron/tests/unit/agent/linux/test_async_process.py:        mock_kill_event.send.assert_called_once()
  neutron/tests/unit/agent/linux/test_async_process.py:            mock_kill_process.assert_called_once(pid)
  neutron/tests/unit/test_dhcp_agent.py:            log.error.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_dhcp_agent.py:        device.route.get_gateway.assert_called_once()
  neutron/tests/unit/test_post_mortem_debug.py:        mock_post_mortem.assert_called_once()
  neutron/tests/unit/test_linux_interface.py:            log.assert_called_once()
  neutron/tests/unit/test_l3_agent.py:        self.send_arp.assert_called_once()
  neutron/tests/unit/test_l3_agent.py:        self.send_arp.assert_called_once()
  neutron/tests/unit/test_l3_agent.py:        self.send_arp.assert_called_once()
  neutron/tests/unit/test_l3_agent.py:        self.send_arp.assert_called_once()
  neutron/tests/unit/test_l3_agent.py:        self.send_arp.assert_called_once()
  neutron/tests/unit/cisco/test_nexus_plugin.py:            mock_db.assert_called_once()
  neutron/tests/unit/linuxbridge/test_lb_neutron_agent.py:                exec_fn.assert_called_once()
  neutron/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py:            mock_driver_update_firewall.assert_called_once(
  neutron/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py:            mock_driver_delete_firewall.assert_called_once(

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1300265/+subscriptions