← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1475796] Re: using pysaml2 version 3.0.0 breaks keystone in kilo release 2015.1.0

 

** Changed in: keystone
       Status: Fix Committed => Fix Released

** Changed in: keystone
    Milestone: None => liberty-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1475796

Title:
  using pysaml2 version 3.0.0 breaks keystone in kilo release 2015.1.0

Status in Keystone:
  Fix Released
Status in Keystone kilo series:
  Fix Committed

Bug description:
  pysaml2 version 3.0.0 it's a major change as specified in [1]:
  "2)All parts of the package is now collected in one module. This is a change that breaking change compared to earlier releases hence the major version change.".

  when running keystone  release 2015.1.0 with python package pysaml2 version 3.0.0 breaks it with the following error:
    File "/usr/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 22, in import_string
      return pkg_resources.EntryPoint.parse("x=" + s).load(False)
    File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2355, in load
      return self.resolve()
    File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2361, in resolve
      module = __import__(self.module_name, fromlist=['__name__'], level=0)
    File "/usr/lib/python2.7/site-packages/keystone/contrib/federation/routers.py", line 17, in <module>
      from keystone.contrib.federation import controllers
    File "/usr/lib/python2.7/site-packages/keystone/contrib/federation/controllers.py", line 29, in <module>
      from keystone.contrib.federation import idp as keystone_idp
    File "/usr/lib/python2.7/site-packages/keystone/contrib/federation/idp.py", line 29, in <module>
      import xmldsig
  ImportError: No module named xmldsig

  
  This is due to the new location for xmldsig module:
  xmldsig -> saml2/xmldsig
  done in commit [2].

  Possible fixes are:

  1) require pysaml2 version <3.0.0
  2) cherry-pick patch from kesytone master branch with the proper fix [3]

  
  [1] - https://github.com/rohe/pysaml2/releases/tag/3.0.0
  [2] - https://github.com/rohe/pysaml2/commit/9af3252035484f4a8c624eba0f35b68280d43fd2
  [3] - https://github.com/openstack/keystone/commit/c90dd3a0f8280e28bbbff691c0ae27aff736658a

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1475796/+subscriptions


References