yahoo-eng-team team mailing list archive

[Alan Pevec <1458928@xxxxxxxxxxxxxxxxxx>]

** Changed in: horizon/kilo
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1458928

Title:
  jshint failing on angular js in stable/kilo

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in OpenStack Dashboard (Horizon) kilo series:
  Fix Released

Bug description:
  http://logs.openstack.org/56/183656/1/check/gate-horizon-
  jshint/cd75430/console.html.gz#_2015-05-15_19_27_08_073

  Looks like this started after 5/14, since there was a passing job
  before that:

  http://logs.openstack.org/21/183321/1/check/gate-horizon-
  jshint/90ca4dd/console.html.gz#_2015-05-14_22_50_02_203

  The only difference I see in external libraries used is tox went from
  1.9.2 (passing) to tox 2.0.1 (failing).  So I'm thinking there is
  something with how the environment is defined for the jshint runs
  because it appears that .jshintrc isn't getting used, see the
  workaround fix here:

  https://review.openstack.org/#/c/185172/

  From the tox 2.0 changelog:

  https://testrun.org/tox/latest/changelog.html

  (new) introduce environment variable isolation: tox now only passes
  the PATH and PIP_INDEX_URL variable from the tox invocation
  environment to the test environment and on Windows also SYSTEMROOT,
  PATHEXT, TEMP and TMP whereas on unix additionally TMPDIR is passed.
  If you need to pass through further environment variables you can use
  the new passenv setting, a space-separated list of environment
  variable names. Each name can make use of fnmatch-style glob patterns.
  All environment variables which exist in the tox-invocation
  environment will be copied to the test environment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1458928/+subscriptions