← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1479842] [NEW] os-brick needs to provide it's own rootwrap filters file

 

Public bug reported:

This came up in the review for the scaleio libvirt volume driver in
nova:

https://review.openstack.org/#/c/194454/16/etc/nova/rootwrap.d/compute.filters

Basically, having to define rootwrap filters in nova and cinder for
things that are run in os-brick is kind of terrible since every time os-
brick needs to add a new command to run as root, it has to be added to
nova/cinder, and we have to deal with version compat issues (will the
version of nova/cinder have the filters required for the version of os-
brick that's running?).

This was already introduced with multipathd to compute.filters in the
os-brick integration change:

https://review.openstack.org/#/c/175569/32/etc/nova/rootwrap.d/compute.filters

Rather than revert the os-brick integration change to nova, we should
work this as a bug so that os-brick can carry it's own os-brick.filters
file and then that can be dropped into /etc/nova/rootwrap.d and
/etc/cinder/rootwrap.d.

So we'll need os-brick changes, nova, cinder and devstack changes to
land this.

Also considered a release blocker for liberty for the nova team.

** Affects: cinder
     Importance: High
         Status: Confirmed

** Affects: devstack
     Importance: Undecided
         Status: Confirmed

** Affects: nova
     Importance: High
         Status: Confirmed

** Affects: os-brick
     Importance: Undecided
         Status: Confirmed


** Tags: liberty-rc-potential

** Also affects: cinder
   Importance: Undecided
       Status: New

** Also affects: os-brick
   Importance: Undecided
       Status: New

** Also affects: devstack
   Importance: Undecided
       Status: New

** Changed in: cinder
       Status: New => Confirmed

** Changed in: nova
       Status: New => Confirmed

** Changed in: devstack
       Status: New => Confirmed

** Changed in: os-brick
       Status: New => Confirmed

** Changed in: cinder
   Importance: Undecided => High

** Changed in: nova
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1479842

Title:
  os-brick needs to provide it's own rootwrap filters file

Status in Cinder:
  Confirmed
Status in devstack:
  Confirmed
Status in OpenStack Compute (nova):
  Confirmed
Status in os-brick:
  Confirmed

Bug description:
  This came up in the review for the scaleio libvirt volume driver in
  nova:

  https://review.openstack.org/#/c/194454/16/etc/nova/rootwrap.d/compute.filters

  Basically, having to define rootwrap filters in nova and cinder for
  things that are run in os-brick is kind of terrible since every time
  os-brick needs to add a new command to run as root, it has to be added
  to nova/cinder, and we have to deal with version compat issues (will
  the version of nova/cinder have the filters required for the version
  of os-brick that's running?).

  This was already introduced with multipathd to compute.filters in the
  os-brick integration change:

  https://review.openstack.org/#/c/175569/32/etc/nova/rootwrap.d/compute.filters

  Rather than revert the os-brick integration change to nova, we should
  work this as a bug so that os-brick can carry it's own os-
  brick.filters file and then that can be dropped into
  /etc/nova/rootwrap.d and /etc/cinder/rootwrap.d.

  So we'll need os-brick changes, nova, cinder and devstack changes to
  land this.

  Also considered a release blocker for liberty for the nova team.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1479842/+subscriptions


Follow ups