yahoo-eng-team team mailing list archive

[Vikhyat Umrao <vumrao@xxxxxxxxxx>]

Public bug reported:

In nova rbd driver rbd features are hard-coded.

                rbd.RBD().clone(src_client.ioctx,
                                     image.encode('utf-8'),
                                     snapshot.encode('utf-8'),
                                     dest_client.ioctx,
                                     dest_name,
                                     features=rbd.RBD_FEATURE_LAYERING)


If We see above given code we are just using RBD_FEATURE_LAYERING directly.
This restrict users to use only hard-coded RBD_FEATURE_LAYERING feature. 

We should give a fix which should allow users to opt in to upcoming
features that have not yet become default and users can specify features
in ceph.conf and nova can read features information from ceph.conf.

Fix should be something like :

Rreading rbd_default_features from ceph.conf for rbd
features configuration, falling back to layering if nothing is found.

** Affects: nova
     Importance: Undecided
     Assignee: Vikhyat Umrao (vumrao)
         Status: In Progress


** Tags: ceph

** Changed in: nova
     Assignee: (unassigned) => Vikhyat Umrao (vumrao)

** Changed in: nova
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1480129

Title:
  nova rbd driver features are hard-coded, it should be readable from
  ceph.conf

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  In nova rbd driver rbd features are hard-coded.

                  rbd.RBD().clone(src_client.ioctx,
                                       image.encode('utf-8'),
                                       snapshot.encode('utf-8'),
                                       dest_client.ioctx,
                                       dest_name,
                                       features=rbd.RBD_FEATURE_LAYERING)

  
  If We see above given code we are just using RBD_FEATURE_LAYERING directly.
  This restrict users to use only hard-coded RBD_FEATURE_LAYERING feature. 

  We should give a fix which should allow users to opt in to upcoming
  features that have not yet become default and users can specify
  features in ceph.conf and nova can read features information from
  ceph.conf.

  Fix should be something like :

  Rreading rbd_default_features from ceph.conf for rbd
  features configuration, falling back to layering if nothing is found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1480129/+subscriptions