yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

This is sort of a follow on update to bug 1383469.

Per
https://github.com/openstack/nova/commit/a6ff9efda33f4e465d5639618da1e2e2105890b6
we no longer do an in-place migration of instance flavor data from
system_metadata to the flavor json blob in the instance_extra table, so
the simple-tentant-usage API shouldn't join on system_metadata anymore:

https://github.com/openstack/nova/blob/12.0.0.0b2/nova/api/openstack/compute/contrib/simple_tenant_usage.py#L107

That should just expect the flavor attribute when pulling the instances
since they are used here:

https://github.com/openstack/nova/blob/12.0.0.0b2/nova/api/openstack/compute/contrib/simple_tenant_usage.py#L84

This is not a high severity bug, but it is a performance nit so we
should fix it.

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: api performance

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1485025

Title:
  The simple-tenant-usage API should pull instance flavor attrs rather
  than system_metadata now

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  This is sort of a follow on update to bug 1383469.

  Per
  https://github.com/openstack/nova/commit/a6ff9efda33f4e465d5639618da1e2e2105890b6
  we no longer do an in-place migration of instance flavor data from
  system_metadata to the flavor json blob in the instance_extra table,
  so the simple-tentant-usage API shouldn't join on system_metadata
  anymore:

  https://github.com/openstack/nova/blob/12.0.0.0b2/nova/api/openstack/compute/contrib/simple_tenant_usage.py#L107

  That should just expect the flavor attribute when pulling the
  instances since they are used here:

  https://github.com/openstack/nova/blob/12.0.0.0b2/nova/api/openstack/compute/contrib/simple_tenant_usage.py#L84

  This is not a high severity bug, but it is a performance nit so we
  should fix it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1485025/+subscriptions