yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

The code and test was added here:

https://review.openstack.org/#/c/194089/

That code has a time.sleep(1) in it but it's not mocked out, making the
test take at least one second:

http://logs.openstack.org/87/212487/1/check/gate-nova-
python27/784bf7e/console.html.gz#_2015-08-13_11_40_21_236

This is a bit of a nit, but we should always be mocking out time.sleep
in unit tests.

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: In Progress


** Tags: hyper-v testing

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1486203

Title:
  nova.tests.unit.virt.hyperv.test_pathutils.PathUtilsTestCase.test_rmtree
  should mock out time.sleep

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  The code and test was added here:

  https://review.openstack.org/#/c/194089/

  That code has a time.sleep(1) in it but it's not mocked out, making
  the test take at least one second:

  http://logs.openstack.org/87/212487/1/check/gate-nova-
  python27/784bf7e/console.html.gz#_2015-08-13_11_40_21_236

  This is a bit of a nit, but we should always be mocking out time.sleep
  in unit tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1486203/+subscriptions