← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1487048] Re: logic error in metadata_to_dict utility function

 

I'm withdrawing this.  The filter_deleted flag should really be named
'include_deleted', and the logic around this is a bit convoluted.  Feel
free to read through the original gerrit reviews to see why this change
was made.

** Changed in: nova
       Status: New => Invalid

** Changed in: nova
     Assignee: Brian Rosmaita (brian-rosmaita) => (unassigned)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1487048

Title:
  logic error in metadata_to_dict utility function

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  Change b7e9a64416ff239a4c1b8501f398796b02c46ce7 introduces a
  filter_deleted flag into the metadata_to_dict function.  The way this
  flag is used at
  https://github.com/openstack/nova/blob/a2d5492e8a15cdc13ada61b03f6293c709160505/nova/utils.py#L850
  however, has the effect that when filter_deleted is true, all instance
  system metadata will be returned in the dict even if such metadata is
  deleted, contrary to the purpose of the flag.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1487048/+subscriptions


References