yahoo-eng-team team mailing list archive

[Timofey Durakov <tdurakov@xxxxxxxxxxxx>]

Public bug reported:

There is _live_migration_cleanup_flags method in compute's manager class which should decide whether it's needed to make cleanup after live-migration is done or not. It accepts 2 params, from doc: 
 :param block_migration: if true, it was a block migration
 :param migrate_data: implementation specific data
The problem is that current compute's manager code is libvirt-specific.
It operates values in migrate_data dictionary that valid only for libvirt driver implementation. 
This doesn't cause any bug yet because other drivers doesn't implement cleanup method at all. 
When anyone decide to implement this live-migration starts to fail. There is no valid ci job to verify that. 

live_migration_cleanup_flags - should become hypervisor specific. and we
should move it from compute manager to drivers.

** Affects: nova
     Importance: Undecided
     Assignee: Timofey Durakov (tdurakov)
         Status: New


** Tags: live-migration

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1487477

Title:
  Mess in live-migration compute-manager and drivers code

Status in OpenStack Compute (nova):
  New

Bug description:
  There is _live_migration_cleanup_flags method in compute's manager class which should decide whether it's needed to make cleanup after live-migration is done or not. It accepts 2 params, from doc: 
   :param block_migration: if true, it was a block migration
   :param migrate_data: implementation specific data
  The problem is that current compute's manager code is libvirt-specific.
  It operates values in migrate_data dictionary that valid only for libvirt driver implementation. 
  This doesn't cause any bug yet because other drivers doesn't implement cleanup method at all. 
  When anyone decide to implement this live-migration starts to fail. There is no valid ci job to verify that. 

  live_migration_cleanup_flags - should become hypervisor specific. and
  we should move it from compute manager to drivers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1487477/+subscriptions