← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1487522] [NEW] Objects: obj_reset_changes signature doesn't match

 

Public bug reported:

If an object contains a Flavor object within it and obj_reset_changes is
called with recursive=True it will fail with the following error.  This
is because Flavor.obj_reset_changes is missing the recursive param in
it's signature.  The Instance object is also missing this parameter in
its method.

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "nova/tests/unit/objects/test_request_spec.py", line 284, in test_save
        req_obj.obj_reset_changes(recursive=True)
      File "nova/objects/base.py", line 224, in obj_reset_changes
        value.obj_reset_changes(recursive=True)
    TypeError: obj_reset_changes() got an unexpected keyword argument 'recursive'

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1487522

Title:
  Objects: obj_reset_changes signature doesn't match

Status in OpenStack Compute (nova):
  New

Bug description:
  If an object contains a Flavor object within it and obj_reset_changes
  is called with recursive=True it will fail with the following error.
  This is because Flavor.obj_reset_changes is missing the recursive
  param in it's signature.  The Instance object is also missing this
  parameter in its method.

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "nova/tests/unit/objects/test_request_spec.py", line 284, in test_save
          req_obj.obj_reset_changes(recursive=True)
        File "nova/objects/base.py", line 224, in obj_reset_changes
          value.obj_reset_changes(recursive=True)
      TypeError: obj_reset_changes() got an unexpected keyword argument 'recursive'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1487522/+subscriptions


Follow ups