yahoo-eng-team team mailing list archive

[Brian Haley <1488284@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The IP conntrack manager code that recently merged in
https://review.openstack.org/#/c/147713/ is sometimes throwing an
AttributeError, see:

http://logs.openstack.org/91/215791/2/check/gate-tempest-dsvm-neutron-
dvr/4e71df4/logs/screen-q-agt.txt.gz?level=WARNING#_2015-08-24_20_19_11_591

This is due to some bad logic in an if statement:

    if not (device_info or pre_device_info):
            continue

That is meant to catch the case where either variable is False, but it
can't the way it's written, it should be:

    if not device_info or not pre_device_info:
        continue

Change Id was Ibfd2d6a11aa970ea9e5009f4c4b858544d8b7463

** Affects: neutron
     Importance: Undecided
     Assignee: Brian Haley (brian-haley)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Brian Haley (brian-haley)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1488284

Title:
  _clean_updated_sg_member_conntrack_entries() is throwing an
  AttributeError occasionally

Status in neutron:
  New

Bug description:
  The IP conntrack manager code that recently merged in
  https://review.openstack.org/#/c/147713/ is sometimes throwing an
  AttributeError, see:

  http://logs.openstack.org/91/215791/2/check/gate-tempest-dsvm-neutron-
  dvr/4e71df4/logs/screen-q-agt.txt.gz?level=WARNING#_2015-08-24_20_19_11_591

  This is due to some bad logic in an if statement:

      if not (device_info or pre_device_info):
              continue

  That is meant to catch the case where either variable is False, but it
  can't the way it's written, it should be:

      if not device_info or not pre_device_info:
          continue

  Change Id was Ibfd2d6a11aa970ea9e5009f4c4b858544d8b7463

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1488284/+subscriptions