yahoo-eng-team team mailing list archive

[Eugene Nikanorov <enikanorov@xxxxxxxxxxxx>]

Public bug reported:

Writing two error messages with different text for a single event is not a good practice.
It reduces readability and search convenience and also may affect UX in case log monitoring is enabled.

 def _bind_centralized_snat_port_on_dvr_subnet(self, port, lvm, fixed_ips, device_owner):
         if port.vif_id in self.local_ports:
             # throw an error if CSNAT port is already on a different
             # dvr routed subnet
             ovsport = self.local_ports[port.vif_id]
             subs = list(ovsport.get_subnets())
             LOG.error(_LE("Centralized-SNAT port %s already seen on "),
                       port.vif_id)
             LOG.error(_LE("a different subnet %s"), subs[0])
             return

** Affects: neutron
     Importance: Medium
     Assignee: Eugene Nikanorov (enikanorov)
         Status: Invalid


** Tags: l3-dvr-backlog

** Changed in: neutron
       Status: New => Confirmed

** Tags added: l3-dvr-backlog

** Changed in: neutron
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1490961

Title:
  Fix doubled error message for a single event

Status in neutron:
  Invalid

Bug description:
  Writing two error messages with different text for a single event is not a good practice.
  It reduces readability and search convenience and also may affect UX in case log monitoring is enabled.

   def _bind_centralized_snat_port_on_dvr_subnet(self, port, lvm, fixed_ips, device_owner):
           if port.vif_id in self.local_ports:
               # throw an error if CSNAT port is already on a different
               # dvr routed subnet
               ovsport = self.local_ports[port.vif_id]
               subs = list(ovsport.get_subnets())
               LOG.error(_LE("Centralized-SNAT port %s already seen on "),
                         port.vif_id)
               LOG.error(_LE("a different subnet %s"), subs[0])
               return

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1490961/+subscriptions