← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1493980] [NEW] The NullHandler and StandardLogging test fixtures don't appear to be detecting formatting errors

 

Public bug reported:

We have the NullHandler and StandardLogging fixtures here to detect
formatting errors in the nova logs:

http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/fixtures.py#n61

We've seen a few bugs recently where we weren't substituting variables
in the log messages but didn't notice until after the fact:

https://review.openstack.org/#/c/220253/

https://review.openstack.org/#/c/221910/

It also appears we should be using the logging_error fixture from
oslo.log:

http://git.openstack.org/cgit/openstack/oslo.log/tree/oslo_log/fixture/logging_error.py

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1493980

Title:
  The NullHandler and StandardLogging test fixtures don't appear to be
  detecting formatting errors

Status in OpenStack Compute (nova):
  New

Bug description:
  We have the NullHandler and StandardLogging fixtures here to detect
  formatting errors in the nova logs:

  http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/fixtures.py#n61

  We've seen a few bugs recently where we weren't substituting variables
  in the log messages but didn't notice until after the fact:

  https://review.openstack.org/#/c/220253/

  https://review.openstack.org/#/c/221910/

  It also appears we should be using the logging_error fixture from
  oslo.log:

  http://git.openstack.org/cgit/openstack/oslo.log/tree/oslo_log/fixture/logging_error.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1493980/+subscriptions


Follow ups