yahoo-eng-team team mailing list archive

[liyuanyuan <liyuanyuan.fnst@xxxxxxxxxxxxxx>]

Public bug reported:

in file glance/api/v2/metadef_namespaces.py, Line 468

468         if limit < 0:
469             msg = _("limit param must be positive")
470             raise webob.exc.HTTPBadRequest(explanation=msg)

I think ignore the zero condition and according to #http://developer.openstack.org/api-ref-image-v2.html
explain (Requests a specified page size of returned items from the query. Returns a number of items up to the specified limit value. Use the limit parameter to make an initial limited request and use the ID of the last-seen item from the response as the marker parameter value in a subsequent limited request. )

I think Line468 it should change to 'if limit <= 0:'

** Affects: glance
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1494169

Title:
  Fix condition mistake for limit argument check

Status in Glance:
  New

Bug description:
  in file glance/api/v2/metadef_namespaces.py, Line 468

  468         if limit < 0:
  469             msg = _("limit param must be positive")
  470             raise webob.exc.HTTPBadRequest(explanation=msg)

  I think ignore the zero condition and according to #http://developer.openstack.org/api-ref-image-v2.html
  explain (Requests a specified page size of returned items from the query. Returns a number of items up to the specified limit value. Use the limit parameter to make an initial limited request and use the ID of the last-seen item from the response as the marker parameter value in a subsequent limited request. )

  I think Line468 it should change to 'if limit <= 0:'

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1494169/+subscriptions