yahoo-eng-team team mailing list archive

[Cindy Lu <clu@xxxxxxxxxx>]

Public bug reported:

As suggested by Travis here:
https://review.openstack.org/#/c/217437/3/openstack_dashboard/static/app/core/images/table
/images-table.controller.js

Instead of defining

ctrl.sourceFilterStrings = {	
      cancel: gettext('Cancel'),	
      prompt: gettext('Click here for filters.'),	
      remove: gettext('Remove'),
      text: gettext('In current results')
}

everywhere, we can just make it a default in hzMagicSearchBar directive.
If user doesn't pass in any filterStrings, we use the default instead.

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1494532

Title:
  Magic Search filtering should provide default help content

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  As suggested by Travis here:
  https://review.openstack.org/#/c/217437/3/openstack_dashboard/static/app/core/images/table
  /images-table.controller.js

  Instead of defining

  ctrl.sourceFilterStrings = {	
        cancel: gettext('Cancel'),	
        prompt: gettext('Click here for filters.'),	
        remove: gettext('Remove'),
        text: gettext('In current results')
  }

  everywhere, we can just make it a default in hzMagicSearchBar
  directive.  If user doesn't pass in any filterStrings, we use the
  default instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1494532/+subscriptions