yahoo-eng-team team mailing list archive

[liyuanyuan <liyuanyuan.fnst@xxxxxxxxxxxxxx>]

** Changed in: glance
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1494583

Title:
  Fix _get_filters method for task type's check

Status in Glance:
  Invalid

Bug description:
  in file glance/api/v2/tasks.py, Line 162

  the method '_get_filters', 
  161   if type:
  162             if type not in ['import']:
  163                 msg = _('Invalid type value: %s') % type
  164                 raise webob.exc.HTTPBadRequest(explanation=msg)

  I think the type is wrong, #http://developer.openstack.org/api-ref-
  image-v2.html#os-tasks-v2

  GET /v2/tasks
  Request parameters
  type (Optional) 	query 	xsd:string 	
  Filters by a specified task type. A valid value is import, export, or clone. 

  I think the condition should change to  'if type not in ['import',
  "export", "clone"]:'

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1494583/+subscriptions