yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

There are several tests in
http://git.openstack.org/cgit/openstack/nova/tree/devstack/tempest-dsvm-
cells-rc which are skipped in devstack + tempest + cells runs because
cells doesn't support security groups.

Some of these are obvious, like:

# skip security group tests
r="$r(?:tempest\.api\.compute\.security_groups.*)"

There are others, like scenario tests (test_stamp_pattern) which don't
work with cells because they create a security group for the server
instance being tested:

http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_stamp_pattern.py#n155

Since security group usage in nova is optional (openstack-infra doesn't
use them since RAX doesn't support them - due to cells), Tempest should
have a compute-feature-enabled.security_groups config option in here:

http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py#n315

That would default to True for backwards compatibility with Tempest.

Then in devstack/lib/tempest if we're running with cells, we can set
compute-feature-enabled.security_groups=False so that jobs running
tempest + devstack + cells don't run those tests.

Once we have that devstack change, we can remove the tests from tempest-
dsvm-cells-rc which are only skipped because of security groups.

Note that the Tempest change which adds the compute-feature-
enabled.security_groups config option will also have to go through and
add skip checks for any tests that are creating and using security
groups on server instances.

So the chain of changes would be:

1. Tempest
2. devstack
3. nova

The nova change would be similar to how this was done:

https://review.openstack.org/#/c/220158/

** Affects: devstack
     Importance: Undecided
         Status: Confirmed

** Affects: nova
     Importance: Low
         Status: Confirmed

** Affects: tempest
     Importance: Undecided
         Status: Confirmed


** Tags: cells testing

** Changed in: nova
       Status: New => Confirmed

** Changed in: nova
   Importance: Undecided => Low

** Also affects: tempest
   Importance: Undecided
       Status: New

** Also affects: devstack
   Importance: Undecided
       Status: New

** Changed in: devstack
       Status: New => Confirmed

** Changed in: tempest
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1495653

Title:
  Clean out security group tests from tempest-dsvm-cells-rc

Status in devstack:
  Confirmed
Status in OpenStack Compute (nova):
  Confirmed
Status in tempest:
  Confirmed

Bug description:
  There are several tests in
  http://git.openstack.org/cgit/openstack/nova/tree/devstack/tempest-
  dsvm-cells-rc which are skipped in devstack + tempest + cells runs
  because cells doesn't support security groups.

  Some of these are obvious, like:

  # skip security group tests
  r="$r(?:tempest\.api\.compute\.security_groups.*)"

  There are others, like scenario tests (test_stamp_pattern) which don't
  work with cells because they create a security group for the server
  instance being tested:

  http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_stamp_pattern.py#n155

  Since security group usage in nova is optional (openstack-infra
  doesn't use them since RAX doesn't support them - due to cells),
  Tempest should have a compute-feature-enabled.security_groups config
  option in here:

  http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py#n315

  That would default to True for backwards compatibility with Tempest.

  Then in devstack/lib/tempest if we're running with cells, we can set
  compute-feature-enabled.security_groups=False so that jobs running
  tempest + devstack + cells don't run those tests.

  Once we have that devstack change, we can remove the tests from
  tempest-dsvm-cells-rc which are only skipped because of security
  groups.

  Note that the Tempest change which adds the compute-feature-
  enabled.security_groups config option will also have to go through and
  add skip checks for any tests that are creating and using security
  groups on server instances.

  So the chain of changes would be:

  1. Tempest
  2. devstack
  3. nova

  The nova change would be similar to how this was done:

  https://review.openstack.org/#/c/220158/

To manage notifications about this bug go to:
https://bugs.launchpad.net/devstack/+bug/1495653/+subscriptions