yahoo-eng-team team mailing list archive

[Mathieu Gagné <1499041@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Both [libvirt]/live_migration_flag and [libvirt]/block_migration_flag
Nova configs exist. They are used to tweak flags used for live migration
without block migration and with block migration. (toggled by --block-
migrate flag of nova live-migration command)

The default values are correct where [libvirt]/live_migration_flag
doesn't have "VIR_MIGRATE_NON_SHARED_INC" flag:

    live_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE, VIR_MIGRATE_TUNNELLED
    block_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE, VIR_MIGRATE_TUNNELLED, VIR_MIGRATE_NON_SHARED_INC

If you add the VIR_MIGRATE_NON_SHARED_INC or VIR_MIGRATE_NON_SHARED_DISK
flag to [libvirt]/live_migration_flag Nova config by mistake, Nova will
happily ALWAYS block migration your disks or volumes. This can result in
serious data corruption on migrated volumes since volumes will be copied
onto themselves.

Nova should add a safeguard so an operator can't add the
VIR_MIGRATE_NON_SHARED_INC or VIR_MIGRATE_NON_SHARED_DISK flags by
mistake.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1499041

Title:
  [libvirt]/live_migration_flag accepts block migration related flags

Status in OpenStack Compute (nova):
  New

Bug description:
  Both [libvirt]/live_migration_flag and [libvirt]/block_migration_flag
  Nova configs exist. They are used to tweak flags used for live
  migration without block migration and with block migration. (toggled
  by --block-migrate flag of nova live-migration command)

  The default values are correct where [libvirt]/live_migration_flag
  doesn't have "VIR_MIGRATE_NON_SHARED_INC" flag:

      live_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE, VIR_MIGRATE_TUNNELLED
      block_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE, VIR_MIGRATE_TUNNELLED, VIR_MIGRATE_NON_SHARED_INC

  If you add the VIR_MIGRATE_NON_SHARED_INC or
  VIR_MIGRATE_NON_SHARED_DISK flag to [libvirt]/live_migration_flag Nova
  config by mistake, Nova will happily ALWAYS block migration your disks
  or volumes. This can result in serious data corruption on migrated
  volumes since volumes will be copied onto themselves.

  Nova should add a safeguard so an operator can't add the
  VIR_MIGRATE_NON_SHARED_INC or VIR_MIGRATE_NON_SHARED_DISK flags by
  mistake.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1499041/+subscriptions