yahoo-eng-team team mailing list archive

[Doug Fish <drfish@xxxxxxxxxx>]

I see that IndexView now extends DataTableView as desired.
https://github.com/openstack/horizon/blob/stable/liberty/openstack_dashboard/dashboards/admin/flavors/views.py#L37

It's a bit curious to me because that has been in place since before
this bug was opened. But in any case, it doesn't seem to be a problem
now.

Also the related template
https://github.com/openstack/horizon/blob/stable/liberty/openstack_dashboard/dashboards/admin/flavors/templates/flavors/index.html
doesn't extend from modal.html.

This wishlist bug has been open a year without any activity. I'm going
to move it to "Fix Released" because it appears the work wish for has
already been completed. This bug can be reopened (set back to "new") if
someone decides to work further on this.

** Changed in: horizon
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1334677

Title:
  Flavor extra specs should be refactored

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The IndexView is extending from ModalFormMixin when there is no
  intention to display a modal or allow form actions in the Index. The
  index only displays a table of the key/value pairs so extending from
  DataTableView should be enough

  The template _index.html is unnecessarily extending form _modal.html
  when there is no intention to display a modal

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1334677/+subscriptions