| Thread Previous • Date Previous • Date Next • Thread Next |
** Also affects: networking-cisco
Importance: Undecided
Status: New
** No longer affects: neutron
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1205172
Title:
Eliminate 1-line static _should_call_create_net() in Cisco plugin
Status in networking-cisco:
New
Bug description:
Perform some miscellaneous cleanup in the Cisco Nexus plugin:
- Eliminate the single-line static method _should_call_create_net(). This method was originally added
as a unit test hook (it was a method which could be mocked to force creation of a network
regardless of instance ID and device_owner in unit testing). This can be eliminated by first
changing the unit tests so that an instance ID is set in unit tests. Once an instance ID is
set, the check in _should_call_create_net() can be moved to the calling method (create_port()).
- Eliminate the try/except in nexus_db_v2.py::get_port_switch_bindings(). This try/except is
designed to catch a NoResultFound exception for a call to all(). However, If there are no
matching entries, all() will simply return None, so this try/except has no value.
To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-cisco/+bug/1205172/+subscriptions
| Thread Previous • Date Previous • Date Next • Thread Next |
