yahoo-eng-team team mailing list archive

[Armando Migliaccio <1204686@xxxxxxxxxxxxxxxxxx>]

** Also affects: vmware-nsx
   Importance: Undecided
       Status: New

** No longer affects: neutron

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1204686

Title:
  Nicira unit tests should not rely on 'fake API client' data

Status in vmware-nsx:
  New

Bug description:
  Several Nicira unit tests verify the result of NVP operations leveraging data stored in the fake nvp api client.
  Due to parallel testing, other threads might be operating on the same data structure, thus adding/removing data which might cause failures in unit tests asserting on the number of items in the dict.

  Mitigation strategies include:
  1 - avoid usage of these dicts at all, whenever possible.
  2 - consider not using the fake api client at all, and mock nvplib calls instead
  3 - always address peculiar elements in the dict, do not make assertions on the whole dictionary (such as len).

  Long term strategy is to not use anymore the fake nvp api client, at least in the plugin tests.
  nvplib calls might just be mocked, considering that nvplib unit tests are in place
  (This is not in the scope of this bug report

To manage notifications about this bug go to:
https://bugs.launchpad.net/vmware-nsx/+bug/1204686/+subscriptions