yahoo-eng-team team mailing list archive

["Davanum Srinivas \(DIMS\)" <davanum@xxxxxxxxx>]

Fixed in https://review.openstack.org/#/c/233165/

** Also affects: oslo.versionedobjects
   Importance: Undecided
       Status: New

** Changed in: oslo.versionedobjects
       Status: New => Fix Committed

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1504534

Title:
  o.vo master + nova master = unit tests fail

Status in OpenStack Compute (nova):
  Invalid
Status in oslo.versionedobjects:
  Fix Committed

Bug description:
  There's a whole bunch of test failures:
  http://paste.openstack.org/show/475867/

  Here's one example if the paste vanishes for some reason:
  nova.tests.unit.objects.test_instance.TestRemoteInstanceListObject.test_get_hung_in_rebooting
  ---------------------------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "nova/tests/unit/objects/test_instance.py", line 1597, in test_get_hung_in_rebooting
          self.assertIsInstance(inst_list.objects[i], objects.Instance)
        File "/home/travis/build/dims/nova/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py", line 401, in assertIsInstance
          self.assertThat(obj, matcher, msg)
        File "/home/travis/build/dims/nova/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat
          raise mismatch_error
      testtools.matchers._impl.MismatchError: 'Instance(access_ip_v4=1.2.3.4,access_ip_v6=::1,architecture=None,auto_disk_config=False,availability_zone=None,cell_name=None,cleaned=False,config_drive=None,created_at=None,default_ephemeral_device=None,default_swap_device=None,deleted=False,deleted_at=None,disable_terminate=False,display_description=None,display_name=None,ec2_ids=<?>,ephemeral_gb=0,ephemeral_key_uuid=None,fault=<?>,flavor=<?>,host='fake-host',hostname=None,id=2,image_ref=None,info_cache=<?>,instance_type_id=None,kernel_id=None,key_data=None,key_name=None,launch_index=None,launched_at=1955-11-12T22:04:00Z,launched_on=None,locked=False,locked_by=None,memory_mb=None,metadata=<?>,migration_context=<?>,new_flavor=<?>,node=None,numa_topology=<?>,old_flavor=<?>,os_type=None,pci_devices=<?>,pci_requests=<?>,power_state=None,progress=None,project_id='fake-project',ramdisk_id=None,reservation_id=None,root_device_name=None,root_gb=0,scheduled_at=<?>,security_groups=<?>,shutdown_terminate=False,system_metadata=<?>,tags=<?>,task_state=None,terminated_at=None,updated_at=None,user_data=None,user_id='fake-user',uuid=c2169c75-2912-4a72-8df9-e3faa5f16578,vcpu_model=<?>,vcpus=None,vm_mode=None,vm_state=None)' is not an instance of InstanceV2

  @bauwser commented on IRC

  bauwser dimsum__: oh man, I see 38 hits on isinstance([^,]+, objects.Instance)
  bauwser dimsum__: which means all of them need to be changed
  bauwser dimsum__: to be isinstance(obj, instance_obj._BaseInstance)

  
  What could be changed is in http://paste.openstack.org/show/475871/ (bauzas - 2015/10/09)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1504534/+subscriptions