← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1505282] [NEW] L3 agent: explicit call to resync on init may lead to double syncing

 

Public bug reported:

Currently L3 agent has an explicit call to self.periodic_sync_routers_task() after initialization. 
Given that periodic job spacing is set to 1 second, this may lead to double syncing with server on initialization (especially if there are a lot of routers scheduled to the agent):
 - agent starts, fullsync flag is True
 - periodic_sync_routers_task is called from after_start(), agent requests router info from server, fullsync flag is True
 - periodic_sync_routers_task is called by periodic task framework, fullsync flag is still True, agent requests router info from server once again.
So it's double work on both server and agent sides which might be quite expensive at scale.

The proposal is to just use run_immediately parameter.

** Affects: neutron
     Importance: Undecided
     Assignee: Oleg Bondarev (obondarev)
         Status: New


** Tags: l3-ipam-dhcp

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1505282

Title:
  L3 agent: explicit call to resync on init may lead to double syncing

Status in neutron:
  New

Bug description:
  Currently L3 agent has an explicit call to self.periodic_sync_routers_task() after initialization. 
  Given that periodic job spacing is set to 1 second, this may lead to double syncing with server on initialization (especially if there are a lot of routers scheduled to the agent):
   - agent starts, fullsync flag is True
   - periodic_sync_routers_task is called from after_start(), agent requests router info from server, fullsync flag is True
   - periodic_sync_routers_task is called by periodic task framework, fullsync flag is still True, agent requests router info from server once again.
  So it's double work on both server and agent sides which might be quite expensive at scale.

  The proposal is to just use run_immediately parameter.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1505282/+subscriptions


Follow ups