yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #40090
[Bug 1474228] Re: inline edit failed in user table because description doesn't exists
** Changed in: horizon/kilo
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1474228
Title:
inline edit failed in user table because description doesn't exists
Status in OpenStack Dashboard (Horizon):
Fix Released
Status in OpenStack Dashboard (Horizon) kilo series:
Fix Released
Bug description:
inline edit failed in user table because description doesn't exits
Environment:
ubuntu devstack stable/kilo
horizon commit id: c2b543bb8f3adb465bb7e8b3774b3dd1d5d999f6
keystone commit id: 8125a8913d233f3da0eaacd09aa8e0b794ea98cb
$keystone --version
/home/user/.virtualenvs/test-horizon/local/lib/python2.7/site-packages/keystoneclient/shell.py:64: DeprecationWarning: The keystone CLI is deprecated in favor of python-openstackclient. For a Python library, continue using python-keystoneclient.
'python-keystoneclient.', DeprecationWarning)
1.6.0
How to reproduce the bug:
1. create a new user. (important)
2. Try to edit user using inline edit.
Note:
If you edit the user using inline edit and the user was edited by
update user form ever, the exception will not raise because the update
form set description to empty string.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/forms.py#L195
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/forms.py#L228
Traceback:
Internal Server Error: /identity/users/
Traceback (most recent call last):
File "/home/user/.virtualenvs/test-horizon/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/user/github/horizon/horizon/decorators.py", line 36, in dec
return view_func(request, *args, **kwargs)
File "/home/user/github/horizon/horizon/decorators.py", line 52, in dec
return view_func(request, *args, **kwargs)
File "/home/user/github/horizon/horizon/decorators.py", line 36, in dec
return view_func(request, *args, **kwargs)
File "/home/user/.virtualenvs/test-horizon/local/lib/python2.7/site-packages/django/views/generic/base.py", line 69, in view
return self.dispatch(request, *args, **kwargs)
File "/home/user/.virtualenvs/test-horizon/local/lib/python2.7/site-packages/django/views/generic/base.py", line 87, in dispatch
return handler(request, *args, **kwargs)
File "/home/user/github/horizon/horizon/tables/views.py", line 224, in post
return self.get(request, *args, **kwargs)
File "/home/user/github/horizon/horizon/tables/views.py", line 160, in get
handled = self.construct_tables()
File "/home/user/github/horizon/horizon/tables/views.py", line 145, in construct_tables
preempted = table.maybe_preempt()
File "/home/user/github/horizon/horizon/tables/base.py", line 1533, in maybe_preempt
new_row)
File "/home/user/github/horizon/horizon/tables/base.py", line 1585, in inline_edit_handle
error = exceptions.handle(request, ignore=True)
File "/home/user/github/horizon/horizon/exceptions.py", line 361, in handle
six.reraise(exc_type, exc_value, exc_traceback)
File "/home/user/github/horizon/horizon/tables/base.py", line 1580, in inline_edit_handle
cell_name)
File "/home/user/github/horizon/horizon/tables/base.py", line 1606, in inline_update_action
self.request, datum, obj_id, cell_name, new_cell_value)
File "/home/user/github/horizon/horizon/tables/actions.py", line 952, in action
self.update_cell(request, datum, obj_id, cell_name, new_cell_value)
File "/home/user/github/horizon/openstack_dashboard/dashboards/identity/users/tables.py", line 210, in update_cell
horizon_exceptions.handle(request, ignore=True)
File "/home/user/github/horizon/horizon/exceptions.py", line 361, in handle
six.reraise(exc_type, exc_value, exc_traceback)
File "/home/user/github/horizon/openstack_dashboard/dashboards/identity/users/tables.py", line 200, in update_cell
description=user_obj.description,
File "/home/user/.virtualenvs/test-horizon/local/lib/python2.7/site-packages/keystoneclient/openstack/common/apiclient/base.py", line 494, in __getattr__
raise AttributeError(k)
AttributeError: description
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1474228/+subscriptions
References