yahoo-eng-team team mailing list archive

[Kevin Benton <1505908@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

We're trying to have DB error retry operations handled at the API layer
(e.g. [1][2]). However, several have snuck into the ML2 plugin[3] so
it's not clear which decorator is responsible for specific errors that
occur and it's not clear if a transaction is still ongoing leading to
repeatable read problems.

We should keep these at one level of the pipeline to make
troubleshooting easier and to avoid confusion about what state
everything will be in when things are retried.


1. https://github.com/openstack/neutron/blob/cecf2a5883744a4aa3ece3194919b2037d007b3f/neutron/api/rpc/handlers/dhcp_rpc.py#L166
2. https://github.com/openstack/neutron/blob/cecf2a5883744a4aa3ece3194919b2037d007b3f/neutron/api/v2/base.py#L404
3. https://github.com/openstack/neutron/blob/cecf2a5883744a4aa3ece3194919b2037d007b3f/neutron/plugins/ml2/plugin.py#L879

** Affects: neutron
     Importance: Undecided
     Assignee: Kevin Benton (kevinbenton)
         Status: In Progress

** Changed in: neutron
     Assignee: (unassigned) => Kevin Benton (kevinbenton)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1505908

Title:
  inconsistent locations of retry decorators

Status in neutron:
  In Progress

Bug description:
  We're trying to have DB error retry operations handled at the API
  layer (e.g. [1][2]). However, several have snuck into the ML2
  plugin[3] so it's not clear which decorator is responsible for
  specific errors that occur and it's not clear if a transaction is
  still ongoing leading to repeatable read problems.

  We should keep these at one level of the pipeline to make
  troubleshooting easier and to avoid confusion about what state
  everything will be in when things are retried.

  
  1. https://github.com/openstack/neutron/blob/cecf2a5883744a4aa3ece3194919b2037d007b3f/neutron/api/rpc/handlers/dhcp_rpc.py#L166
  2. https://github.com/openstack/neutron/blob/cecf2a5883744a4aa3ece3194919b2037d007b3f/neutron/api/v2/base.py#L404
  3. https://github.com/openstack/neutron/blob/cecf2a5883744a4aa3ece3194919b2037d007b3f/neutron/plugins/ml2/plugin.py#L879

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1505908/+subscriptions