yahoo-eng-team team mailing list archive

[Tony Dunbar <adunbar@xxxxxxxxxx>]

Public bug reported:

In

https://github.com/openstack/nova/blob/4cf6ef68199183697a0209751575f88fe5b2a733/nova/compute/vm_states.py#L40

the vm_state SOFT_DELETED is mapped to the value 'soft-delete.  All the
other vm_states are mapped to values that match their state in lower
case, so to be consistent SOFT_DELETED should map to 'soft_deleted'.

I searched through the Nova code and did not find any references to
soft-delete, so a change should not cause any breakage.

In Horizon's instance table here:

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L1001

the value expected is 'soft_deleted', so changing the value in nova to
be consistent should help.

** Affects: nova
     Importance: Undecided
     Assignee: Tony Dunbar (adunbar)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Tony Dunbar (adunbar)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1506177

Title:
  vm_state 'soft-delete' should be 'soft_deleted'

Status in OpenStack Compute (nova):
  New

Bug description:
  In

  https://github.com/openstack/nova/blob/4cf6ef68199183697a0209751575f88fe5b2a733/nova/compute/vm_states.py#L40

  the vm_state SOFT_DELETED is mapped to the value 'soft-delete.  All
  the other vm_states are mapped to values that match their state in
  lower case, so to be consistent SOFT_DELETED should map to
  'soft_deleted'.

  I searched through the Nova code and did not find any references to
  soft-delete, so a change should not cause any breakage.

  In Horizon's instance table here:

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L1001

  the value expected is 'soft_deleted', so changing the value in nova to
  be consistent should help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1506177/+subscriptions