yahoo-eng-team team mailing list archive

[Elena Ezhova <eezhova@xxxxxxxxxxxx>]

Public bug reported:

l3-agent, as well as other neutron services is launched using oslo.service which sets handlers for such signals as SIGTERM and SIGHUP. On receiving SIGHUP a service is supposed to reload its config files and restart. [1]
Meanwhile, this is not so for l3 agent. ProcessDelegation class that is instantiated in L3NATAgent overrides handler for SIGHUP [2], thus removing handler that was set in oslo.service.

To restore the expected behavior self.pd_update_cb() should be moved to
the reset method.

[1] http://docs.openstack.org/developer/oslo.service/usage.html#signal-handling
[2] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/pd.py#L281-L288

** Affects: neutron
     Importance: Undecided
     Assignee: Elena Ezhova (eezhova)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Elena Ezhova (eezhova)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1511401

Title:
  L3 agent no longer restarts on SIGHUP

Status in neutron:
  New

Bug description:
  l3-agent, as well as other neutron services is launched using oslo.service which sets handlers for such signals as SIGTERM and SIGHUP. On receiving SIGHUP a service is supposed to reload its config files and restart. [1]
  Meanwhile, this is not so for l3 agent. ProcessDelegation class that is instantiated in L3NATAgent overrides handler for SIGHUP [2], thus removing handler that was set in oslo.service.

  To restore the expected behavior self.pd_update_cb() should be moved
  to the reset method.

  [1] http://docs.openstack.org/developer/oslo.service/usage.html#signal-handling
  [2] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/pd.py#L281-L288

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1511401/+subscriptions