yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

The logging here:

https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1272-L1273

 LOG.debug("block_device_mapping %s", block_device_mapping,
                  instance_uuid=instance_uuid)

Is useless b/c the block_device_mapping is a BlockDeviceMappingList
object which doesn't repr the sub-objects, so you get this in the logs:

2015-11-06 16:45:08.041 DEBUG nova.compute.api [req-47d3eb5f-
adf0-4cce-8649-56d56eb938e7 tempest-TestVolumeBootPatternV2-460128209
tempest-TestVolumeBootPatternV2-1003926203] [instance: 01b8916e-
97e1-4aa9-95a0-e7278b512a22] block_device_mapping
BlockDeviceMappingList(objects=[BlockDeviceMapping(UNKNOWN)])
_create_block_device_mapping
/opt/stack/new/nova/nova/compute/api.py:1273

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: api logging

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1513934

Title:
  bdm logging in nova.compute.api.API._create_block_device_mapping is
  useless

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  The logging here:

  https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1272-L1273

   LOG.debug("block_device_mapping %s", block_device_mapping,
                    instance_uuid=instance_uuid)

  Is useless b/c the block_device_mapping is a BlockDeviceMappingList
  object which doesn't repr the sub-objects, so you get this in the
  logs:

  2015-11-06 16:45:08.041 DEBUG nova.compute.api [req-47d3eb5f-
  adf0-4cce-8649-56d56eb938e7 tempest-TestVolumeBootPatternV2-460128209
  tempest-TestVolumeBootPatternV2-1003926203] [instance: 01b8916e-
  97e1-4aa9-95a0-e7278b512a22] block_device_mapping
  BlockDeviceMappingList(objects=[BlockDeviceMapping(UNKNOWN)])
  _create_block_device_mapping
  /opt/stack/new/nova/nova/compute/api.py:1273

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1513934/+subscriptions