← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1514550] [NEW] nova.cells.messaging.instance_update_at_top is assuming it gets an Instance object

 

Public bug reported:

This code assumes that the instance parameter is a nova Instance object:

https://github.com/openstack/nova/blob/86fe90f7056432416ea3c2335ea8c2ad6e16b79a/nova/cells/messaging.py#L1020

But if you're using cells RPC API < 1.35 it's a primitive dict:

https://github.com/openstack/nova/blob/86fe90f7056432416ea3c2335ea8c2ad6e16b79a/nova/cells/rpcapi.py#L205

This was introduced with eaaa659333c7586a71155c065dfb0f7b7e3758fc in
12.0.0 (Liberty).

** Affects: nova
     Importance: Low
         Status: Triaged


** Tags: cells low-hanging-fruit unified-objects

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1514550

Title:
  nova.cells.messaging.instance_update_at_top is assuming it gets an
  Instance object

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  This code assumes that the instance parameter is a nova Instance
  object:

  https://github.com/openstack/nova/blob/86fe90f7056432416ea3c2335ea8c2ad6e16b79a/nova/cells/messaging.py#L1020

  But if you're using cells RPC API < 1.35 it's a primitive dict:

  https://github.com/openstack/nova/blob/86fe90f7056432416ea3c2335ea8c2ad6e16b79a/nova/cells/rpcapi.py#L205

  This was introduced with eaaa659333c7586a71155c065dfb0f7b7e3758fc in
  12.0.0 (Liberty).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1514550/+subscriptions


Follow ups