yahoo-eng-team team mailing list archive

[Manjeet Singh Bhatia <manjeet.s.bhatia@xxxxxxxxx>]

Public bug reported:

I see direct values for protocols are used while testing listener and pool.
It would be good to use constants which are already defined. in functional and unit tests.

I was trying to implement its case insensitivity but since protocol value is hardcoded
in most tests so all the test were breaking.

The changes will be easy if we use already defined constants.

** Affects: neutron
     Importance: Undecided
     Assignee: Manjeet Singh Bhatia (manjeet-s-bhatia)
         Status: New


** Tags: lbaas

** Changed in: neutron
     Assignee: (unassigned) => Manjeet Singh Bhatia (manjeet-s-bhatia)

** Tags added: lbaas

** Description changed:

- I see direct values for protocols are used while testing listener and pool. 
+ I see direct values for protocols are used while testing listener and pool.
  It would be good to use constants which are already defined. in functional and unit tests.
  
- 
- I was trying to implement its case insensitivity but since protocol value is hardcoded 
- in most tests so all the test were breaking. 
+ I was trying to implement its case insensitivity but since protocol value is hardcoded
+ in most tests so all the test were breaking.
  
  The changes will be easy if we use already defined constants.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1516296

Title:
  Use constants for protocol values in tests in load balancer comonents

Status in neutron:
  New

Bug description:
  I see direct values for protocols are used while testing listener and pool.
  It would be good to use constants which are already defined. in functional and unit tests.

  I was trying to implement its case insensitivity but since protocol value is hardcoded
  in most tests so all the test were breaking.

  The changes will be easy if we use already defined constants.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1516296/+subscriptions