yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

This code dumps the connection_info dict into the StorageError message:

https://github.com/openstack/nova/blob/12.0.0/nova/virt/xenapi/volume_utils.py#L85-L87

As can be seen a few lines later, auth_password can be in that dict:

https://github.com/openstack/nova/blob/12.0.0/nova/virt/xenapi/volume_utils.py#L96

So the password would be leaked into the error message that's raised up.
This could eventually get back to the logs or a user if not handled
properly.

** Affects: nova
     Importance: High
     Assignee: Matt Riedemann (mriedem)
         Status: Confirmed

** Affects: ossa
     Importance: Undecided
         Status: New


** Tags: xenserver

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1516765

Title:
  xenapi: volume_utils._parse_volume_info can leak connection password
  via StorageError

Status in OpenStack Compute (nova):
  Confirmed
Status in OpenStack Security Advisory:
  New

Bug description:
  This code dumps the connection_info dict into the StorageError
  message:

  https://github.com/openstack/nova/blob/12.0.0/nova/virt/xenapi/volume_utils.py#L85-L87

  As can be seen a few lines later, auth_password can be in that dict:

  https://github.com/openstack/nova/blob/12.0.0/nova/virt/xenapi/volume_utils.py#L96

  So the password would be leaked into the error message that's raised
  up.  This could eventually get back to the logs or a user if not
  handled properly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1516765/+subscriptions