← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1519573] [NEW] Horizon edit-flavor recreates it, even nothing was changed on the edit page.

 

Public bug reported:

How to reproduce:
1. Open falvor list in horizon, click edit flavor, do not change anything and click save. 

Actual results:
New flavor with the same name will be created, old one will be marked as deleted.
 mysql> select * from  instance_types where name like '%test_t3_4xLarge%'\G

*************************** 1. row ***************************
  created_at: 2015-11-25 00:51:43
  updated_at: 2015-11-25 01:23:38
  deleted_at: 2015-11-25 01:23:38
        name: test_t3_4xLarge
          id: 7196
   memory_mb: 65536
       vcpus: 8
        swap: 0
vcpu_weight: NULL
    flavorid: b982c1fc-1a60-432e-bc71-666390fd5a6b
rxtx_factor: 1
     root_gb: 800
ephemeral_gb: 0
    disabled: 0
   is_public: 1
     deleted: 7196

*************************** 2. row ***************************
  created_at: 2015-11-25 01:23:38
  updated_at: NULL
  deleted_at: NULL
        name: test_t3_4xLarge
          id: 7200
   memory_mb: 65536
       vcpus: 8
       swap: 0
vcpu_weight: NULL
    flavorid: 2a1bf35e-cb11-49e6-918e-fd1e6f219d53
rxtx_factor: 1
     root_gb: 800
ephemeral_gb: 0
    disabled: 0
   is_public: 1
     deleted: 0
2 rows in set (0.01 sec)
First one is old. Second is new. Flavor-show now shows new id:
root@dpa2r04c001.dpa2 01:25:07:~# nova flavor-show  test_t3_4xLarge | grep id
| id| 2a1bf35e-cb11-49e6-918e-fd1e6f219d53

Expected results:
If you didn't really change anything on that page horizon should not delete old and create new flavor. This behavior is confusing.
I understand that there is no such api to test it, but it probably should be implemented using javascript. 

Also, it would be good to add this note about what actually happens when you edit flavor to horizon edit-flavor page:
http://docs.openstack.org/openstack-ops/content/flavors.html
"The OpenStack dashboard simulates the ability to modify a flavor by deleting an existing flavor and creating a new one with the same name."

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1519573

Title:
  Horizon edit-flavor recreates it, even nothing was changed on the edit
  page.

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  How to reproduce:
  1. Open falvor list in horizon, click edit flavor, do not change anything and click save. 

  Actual results:
  New flavor with the same name will be created, old one will be marked as deleted.
   mysql> select * from  instance_types where name like '%test_t3_4xLarge%'\G

  *************************** 1. row ***************************
    created_at: 2015-11-25 00:51:43
    updated_at: 2015-11-25 01:23:38
    deleted_at: 2015-11-25 01:23:38
          name: test_t3_4xLarge
            id: 7196
     memory_mb: 65536
         vcpus: 8
          swap: 0
  vcpu_weight: NULL
      flavorid: b982c1fc-1a60-432e-bc71-666390fd5a6b
  rxtx_factor: 1
       root_gb: 800
  ephemeral_gb: 0
      disabled: 0
     is_public: 1
       deleted: 7196

  *************************** 2. row ***************************
    created_at: 2015-11-25 01:23:38
    updated_at: NULL
    deleted_at: NULL
          name: test_t3_4xLarge
            id: 7200
     memory_mb: 65536
         vcpus: 8
         swap: 0
  vcpu_weight: NULL
      flavorid: 2a1bf35e-cb11-49e6-918e-fd1e6f219d53
  rxtx_factor: 1
       root_gb: 800
  ephemeral_gb: 0
      disabled: 0
     is_public: 1
       deleted: 0
  2 rows in set (0.01 sec)
  First one is old. Second is new. Flavor-show now shows new id:
  root@dpa2r04c001.dpa2 01:25:07:~# nova flavor-show  test_t3_4xLarge | grep id
  | id| 2a1bf35e-cb11-49e6-918e-fd1e6f219d53

  Expected results:
  If you didn't really change anything on that page horizon should not delete old and create new flavor. This behavior is confusing.
  I understand that there is no such api to test it, but it probably should be implemented using javascript. 

  Also, it would be good to add this note about what actually happens when you edit flavor to horizon edit-flavor page:
  http://docs.openstack.org/openstack-ops/content/flavors.html
  "The OpenStack dashboard simulates the ability to modify a flavor by deleting an existing flavor and creating a new one with the same name."

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1519573/+subscriptions


Follow ups