← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1519171] Re: model-migration check fails to detect integer-biginteger mismatch

 

The issue here is cause that in model is used with_variant type [1] So,
compare_type method see [2] and seems that it compares them as equal.
This is the only case in Neutron, so there are no other places to fix
this. I will propose patch for oslo.db, not sure that there is something
that should be done on Neutron side.


[1] - https://github.com/openstack/neutron/blob/master/neutron/db/model_base.py#L100
[2] - http://paste.openstack.org/show/480278/

** Changed in: neutron
       Status: Confirmed => Opinion

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1519171

Title:
  model-migration check fails to detect integer-biginteger mismatch

Status in neutron:
  Opinion

Bug description:
  See
  https://review.openstack.org/#/c/222079/15/neutron/db/migration/alembic_migrations/versions/mitaka/expand/32e5974ada25_add_neutron_resources_table.py

  Kevin had Integer in the model and BigInteger in the migration.
  This should be detected by _TestModelsMigrations().

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1519171/+subscriptions


References