← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1521079] [NEW] can't install requirements by Makefile

 

Public bug reported:

`*requirements` target name is wrong, isn't it?.

```
$ make pip-test-requirements
make: Nothing to be done for 'pip-test-requirements'.

$ make pip-test-requirements
Installing cloud-init test dependencies...
pip install -r "pip-test-requirements.txt" -q
Could not open requirements file: [Errno 2] No such file or directory: 'pip-test-requirements.txt'
Makefile:30: recipe for target 'pip-test-requirements' failed
make: *** [pip-test-requirements] Error 1
```

Makefile
```
pip-requirements:
    @echo "Installing cloud-init dependencies..."
    $(PIP_INSTALL) -r "$@.txt" -q

pip-test-requirements:
    @echo "Installing cloud-init test dependencies..."
    $(PIP_INSTALL) -r "$@.txt" -q
```

```
$ ls -l *requirements.txt
-rw-r--r-- 1 vagrant vagrant 948 11月 30 15:12 requirements.txt
-rw-r--r-- 1 vagrant vagrant  71 11月 30 15:12 test-requirements.txt
```

** Affects: cloud-init
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1521079

Title:
  can't install requirements by Makefile

Status in cloud-init:
  New

Bug description:
  `*requirements` target name is wrong, isn't it?.

  ```
  $ make pip-test-requirements
  make: Nothing to be done for 'pip-test-requirements'.

  $ make pip-test-requirements
  Installing cloud-init test dependencies...
  pip install -r "pip-test-requirements.txt" -q
  Could not open requirements file: [Errno 2] No such file or directory: 'pip-test-requirements.txt'
  Makefile:30: recipe for target 'pip-test-requirements' failed
  make: *** [pip-test-requirements] Error 1
  ```

  Makefile
  ```
  pip-requirements:
      @echo "Installing cloud-init dependencies..."
      $(PIP_INSTALL) -r "$@.txt" -q

  pip-test-requirements:
      @echo "Installing cloud-init test dependencies..."
      $(PIP_INSTALL) -r "$@.txt" -q
  ```

  ```
  $ ls -l *requirements.txt
  -rw-r--r-- 1 vagrant vagrant 948 11月 30 15:12 requirements.txt
  -rw-r--r-- 1 vagrant vagrant  71 11月 30 15:12 test-requirements.txt
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1521079/+subscriptions


Follow ups