← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1513645] Re: Inconsistent use of admin/non-admin context in neutron network api while preparing network info

 

@Shraddha Pandhe:
This bug report doesn't seem to describe a bug. It's rather a request
for discussion. As long as there is no actual observation that this is
a failure/fault/error in the behavior of Nova it doesn't make sense 
to open a bug report from my point of view. Pointing to master code
which is constantly evolving doesn't help too. If you have concerns
that some use cases could be affected it's fair to add test cases to
tempest to ensure that the use cases in doubt get tested properly.

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1513645

Title:
  Inconsistent use of admin/non-admin context in neutron network api
  while preparing network info

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  In allocate_for_instance, Neutron network API calls Neutron to create
  the port(s)[1]. Once the port is created, it formats network info in
  network info model, before returning it to Compute Manager [2]. To
  form network info, the API makes several calls to Neutron.

  1. List ports for device id [3]
  2. Get associated floating IPs [4]
  3. Get subnets from port [5] & [6]

  Notice that, in 3 & 4, the API uses admin context to talk to Neutron,
  whereas in 6, it doesn't use admin context.

  This is inconsistent. Is this intentional?


  [1] https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L716
  [2] https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L739-L741
  [3] https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1671-L1676
  [4] https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1555-L1566
  [5] https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1568-L1573
  [6] https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1755-L1756

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1513645/+subscriptions


References