yahoo-eng-team team mailing list archive

[Zhao Zhe <148054685@xxxxxx>]

Public bug reported:

Based on the API: 
http://pubs.vmware.com/vsphere-55/index.jsp#com.vmware.wssdk.apiref.doc/vim.VirtualDiskManager.VirtualDiskAdapterType.html
There is no paraVirtualscsi Constant, so it is rejected by the API as "A specified parameter was not correct".

in nova/virt/vmwareapi/vm_util.py:
def get_vmdk_adapter_type(adapter_type):
    """Return the adapter type to be used in vmdk descriptor.
    Adapter type in vmdk descriptor is same for LSI-SAS, LSILogic & ParaVirtual
    because Virtual Disk Manager API does not recognize the newer controller
    types.
    """
    if adapter_type in [constants.ADAPTER_TYPE_LSILOGICSAS,
                        constants.ADAPTER_TYPE_PARAVIRTUAL]:
        vmdk_adapter_type = constants.DEFAULT_ADAPTER_TYPE
    else:
        vmdk_adapter_type = adapter_type
    return vmdk_adapter_type

in nova/virt/vmwareapi/constants.py
DEFAULT_ADAPTER_TYPE = "lsiLogic"
...
ADAPTER_TYPE_BUSLOGIC = "busLogic"
ADAPTER_TYPE_IDE = "ide"
ADAPTER_TYPE_LSILOGICSAS = "lsiLogicsas"
ADAPTER_TYPE_PARAVIRTUAL = "paraVirtual"

Here we can see, only  "lsiLogicsas" and "paraVirtual" are filtered out as unsupported adapter types and switched to "lsiLogic".
But there are still other unsupported adapter types such as paraVirtualscsi and so on.
So the filter list seems should be extent or errors will occur if other unsupported adapter types are used.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1521458

Title:
  some unsupported vmware adapter types cannot be filtered out

Status in OpenStack Compute (nova):
  New

Bug description:
  Based on the API: 
  http://pubs.vmware.com/vsphere-55/index.jsp#com.vmware.wssdk.apiref.doc/vim.VirtualDiskManager.VirtualDiskAdapterType.html
  There is no paraVirtualscsi Constant, so it is rejected by the API as "A specified parameter was not correct".

  in nova/virt/vmwareapi/vm_util.py:
  def get_vmdk_adapter_type(adapter_type):
      """Return the adapter type to be used in vmdk descriptor.
      Adapter type in vmdk descriptor is same for LSI-SAS, LSILogic & ParaVirtual
      because Virtual Disk Manager API does not recognize the newer controller
      types.
      """
      if adapter_type in [constants.ADAPTER_TYPE_LSILOGICSAS,
                          constants.ADAPTER_TYPE_PARAVIRTUAL]:
          vmdk_adapter_type = constants.DEFAULT_ADAPTER_TYPE
      else:
          vmdk_adapter_type = adapter_type
      return vmdk_adapter_type

  in nova/virt/vmwareapi/constants.py
  DEFAULT_ADAPTER_TYPE = "lsiLogic"
  ...
  ADAPTER_TYPE_BUSLOGIC = "busLogic"
  ADAPTER_TYPE_IDE = "ide"
  ADAPTER_TYPE_LSILOGICSAS = "lsiLogicsas"
  ADAPTER_TYPE_PARAVIRTUAL = "paraVirtual"

  Here we can see, only  "lsiLogicsas" and "paraVirtual" are filtered out as unsupported adapter types and switched to "lsiLogic".
  But there are still other unsupported adapter types such as paraVirtualscsi and so on.
  So the filter list seems should be extent or errors will occur if other unsupported adapter types are used.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1521458/+subscriptions