yahoo-eng-team team mailing list archive

[Bob Ball <1521977@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Other virt drivers (libvirt:
https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/vif.py#n448,
hyperv:
https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/hyperv/vif.py#n66)
plug the VIFs when the vif_driver.plug() method is called.

 XenAPI's vif plug does not plug a device, but returns a dictionary -
see
https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vif.py#n133
- and then "plugs" it during VM creation - see
https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n1881,
called from
https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n547.

This is broken with respect to the names in the interface and what other
virt drivers are doing.

It has further led to functionality being implemented that does nothing,
for example driver.plug_vifs and driver.unplug_vifs make calls to
vif_driver.plug and vif_driver.unplug - but these do nothing.

We need to fix the code so that:

vif_driver.plug will create a new VIF for the VM record
vif_driver.unplug will destroy the VIF record from the VM, if it still exists.

** Affects: nova
     Importance: Medium
         Status: Confirmed


** Tags: xenserver

** Changed in: nova
   Importance: Undecided => Medium

** Tags added: xenserver

** Changed in: nova
       Status: New => Confirmed

** Description changed:

  Other virt drivers (libvirt:
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/vif.py#n448,
  hyperv:
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/hyperv/vif.py#n66)
- plug the VIFs when the vif_driver.plug() method is called.  XenAPI's vif
- plug does not plug a device, but returns a dictionary - see
+ plug the VIFs when the vif_driver.plug() method is called.
+ 
+  XenAPI's vif plug does not plug a device, but returns a dictionary -
+ see
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vif.py#n133
  - and then "plugs" it during VM creation - see
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n1881,
  called from
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n547.
  
  This is broken with respect to the names in the interface and what other
  virt drivers are doing.
  
  It has further led to functionality being implemented that does nothing,
  for example driver.plug_vifs and driver.unplug_vifs make calls to
  vif_driver.plug and vif_driver.unplug - but these do nothing.
  
  We need to fix the code so that:
  
  vif_driver.plug will create a new VIF for the VM record
  vif_driver.unplug will destroy the VIF record from the VM, if it still exists.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1521977

Title:
  XenAPI: XenVIF implementation breaks the interface

Status in OpenStack Compute (nova):
  Confirmed

Bug description:
  Other virt drivers (libvirt:
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/vif.py#n448,
  hyperv:
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/hyperv/vif.py#n66)
  plug the VIFs when the vif_driver.plug() method is called.

   XenAPI's vif plug does not plug a device, but returns a dictionary -
  see
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vif.py#n133
  - and then "plugs" it during VM creation - see
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n1881,
  called from
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n547.

  This is broken with respect to the names in the interface and what
  other virt drivers are doing.

  It has further led to functionality being implemented that does
  nothing, for example driver.plug_vifs and driver.unplug_vifs make
  calls to vif_driver.plug and vif_driver.unplug - but these do nothing.

  We need to fix the code so that:

  vif_driver.plug will create a new VIF for the VM record
  vif_driver.unplug will destroy the VIF record from the VM, if it still exists.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1521977/+subscriptions