← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1521809] Re: No checkpoint if email address entered for user is in email format or not

 

Karan,

Valid point, when we first implemented the jsonschema validation layer
on keystone, we attempted to validate email addresses on user
create/update requests. The functionality for doing this already exists
in jsonschema. The reason we didn't was because the default keystone
identity backend originally stored email in the table's extra column
[0]. The extras column never checked if email addresses were valid or
not. Introducing validation on email addresses would be a backwards
incompatible change to the API, and would require a major revision. We
have a discussion documented in code review around this [1] (see Brant
and Lin's comment on line 21).

Let me know if this helps clear things up.

[0] https://github.com/openstack/keystone/blob/8dd27d3368ce0aa396386010f6aec5ed6304d687/keystone/identity/backends/sql.py#L29-L40
[1] https://review.openstack.org/#/c/132122/6/keystone/identity/schema.py

** Changed in: keystone
       Status: New => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1521809

Title:
  No checkpoint if email address entered for user is in email format or
  not

Status in OpenStack Identity (keystone):
  Won't Fix

Bug description:
  While creating new user if the email address entered by user is not in
  email format then there is no error and is accepted as it is. In case
  of typo in email format there will be no validation so user will not
  be intimated if wrong email format is entered.

  This field can accept anything like phone number, address so the name
  of this should not say email specifically or can be named as
  Remarks/Info

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1521809/+subscriptions


References