yahoo-eng-team team mailing list archive

[Launchpad Bug Tracker <1248820@xxxxxxxxxxxxxxxxxx>]

[Expired for neutron because there has been no activity for 60 days.]

** Changed in: neutron
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1248820

Title:
  plugins delete_port definition is inconsistant

Status in neutron:
  Expired

Bug description:
  Here is delete_port definition in API define and db mixin:

    def delete_port(self, context, id)

  in l3_db.py:, there are some calls to delete_port, ex:

      self._core_plugin.delete_port(context.elevated(), gw_port['id'],
  l3_port_check=False)

  and many plugins have overridden delete_port, accept extra arguments.
  ex:

  neutron/plugins/bigswitch/plugin.py|767| def delete_port(self, context, port_id, l3_port_check=True)
  neutron/plugins/ml2/plugin.py|621| def delete_port(self, context, id, l3_port_check=True)
  neutron/plugins/nicira/NeutronPlugin.py|1322| def delete_port(self, context, id, l3_port_check=True, nw_gw_port_check=True):                                                       

  so the **kwargs should be added to the API define.

  I have also submitted a patch here:

  https://review.openstack.org/#/c/55129

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1248820/+subscriptions