← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1206059] Re: variable prefix q_ leading a bit confusion

 

[Expired for neutron because there has been no activity for 60 days.]

** Changed in: neutron
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1206059

Title:
  variable prefix q_ leading a bit confusion

Status in neutron:
  Expired

Bug description:
  this is not exactly a bug, but code refactor. It can be improved if
  someone would do this job

  the module import statement sometimes may use alias for shorten
  typing, but since quantum changed to neutron, some alias still remain
  the old q_xx. for i.e, in neutron/plugins/nicira/NeutronPlugin.py.

  It will not cause the correctness, but still not explicit, so if
  someone will change it to n_xx, it may be better

  grep ' q_' ./neutron -r | wc -l
  407

  i think sed will simplely do this job.

  And there is some ns-prefix qdhcp-, qrouter- in some files, mainly in
  test code, for i.e. neutron/tests/unit/test_linux_dhcp.py, and there
  is some qg- device prefix in l3_agent.py

  This can be done via sed too.

  But it will be uncomfortable for people who familar with quantum,
  especially the namespace prefix and device prefix. However, the module
  alias still can be refactored

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1206059/+subscriptions