← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1516963] Re: Nova enginefacade uses private fields of oslo.db

 

Reviewed:  https://review.openstack.org/246337
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=da064a388d49c01a022f6545a07101ae74c70d8b
Submitter: Jenkins
Branch:    master

commit da064a388d49c01a022f6545a07101ae74c70d8b
Author: Sergey Nikitin <snikitin@xxxxxxxxxxxx>
Date:   Tue Nov 17 14:15:29 2015 +0300

    Replaced private field in get_session/engine with public method
    
    We use private field _factory to get access to the oslo.db
    method 'get_legacy_facade()'. It's not quite right and
    it could be fixed with the help of the new version of oslo.db.
    
    Closes-Bug: #1516963
    
    Change-Id: I3c5726fdb77a7ab9709f2b1951b673f802c66920


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1516963

Title:
  Nova enginefacade uses private fields of oslo.db

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Right now Nova uses private field _factory to get access to the
  oslo.db method 'get_legacy_facade()'.

  https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L161-L177

  It's not quite right.

  It happend because old verison of oslo.db hasn't a legal way to get
  access to this method.

  The new version of oslo.db can solve this problem

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1516963/+subscriptions


References