yahoo-eng-team team mailing list archive

[Sergey Kraynev <skraynev@xxxxxxxxxxxx>]

Public bug reported:

I use Heat for creating VMs, and one part of new  Heat code (in
stable/liberty and in master) uses nova extensions:

https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server_network_mixin.py#L188

I wanted to find this extension, but faced with following issue:
1. All nova documentation tells about "os-interface" extension instead of "os-attach-interfaces"
2. Also I founded, that nova code has some misunderstanding between alias and name:

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/attach_interfaces.py#L196

it has: alias = "os-attach-interfaces"

But in the same time uses different key for creating extension:

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/attach_interfaces.py#L203

os-interface

The same issue is in name option - it's AttachInterfaces

It looks like bug in naming, because another nova extension has clear naming without such confusion:
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/server_password.py#L54-L64

I'm not sure where it should be fixed: doc vs nova code.

P.s. if you will fix it in code, don't forget to backport it in
stable/liberty too, please.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: liberty-backport-potential

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1525387

Title:
  Wrong naming of nova extension

Status in OpenStack Compute (nova):
  New

Bug description:
  I use Heat for creating VMs, and one part of new  Heat code (in
  stable/liberty and in master) uses nova extensions:

  https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server_network_mixin.py#L188

  I wanted to find this extension, but faced with following issue:
  1. All nova documentation tells about "os-interface" extension instead of "os-attach-interfaces"
  2. Also I founded, that nova code has some misunderstanding between alias and name:

  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/attach_interfaces.py#L196

  it has: alias = "os-attach-interfaces"

  But in the same time uses different key for creating extension:

  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/attach_interfaces.py#L203

  os-interface

  The same issue is in name option - it's AttachInterfaces

  It looks like bug in naming, because another nova extension has clear naming without such confusion:
  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/server_password.py#L54-L64

  I'm not sure where it should be fixed: doc vs nova code.

  P.s. if you will fix it in code, don't forget to backport it in
  stable/liberty too, please.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1525387/+subscriptions