yahoo-eng-team team mailing list archive

[Travis Tripp <1526054@xxxxxxxxxxxxxxxxxx>]

Public bug reported:


Angular Table actions are using a different icon for delete than the django actions. In addition, the spacing and font is different.

http://pasteboard.co/2c1hmge.png

This is in:
https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets
/action-list/actions-delete-selected.template.html


Angular row delete actions have an icon even though their django
counterparts do not.

On the Django table, there is not an icon for row actions. I did a
screen grab below (note that I messed with the code to force it to only
have delete actions).

http://pasteboard.co/2c1hmge.png

If you look at the rendered HTML on the Django table, there does not
appear to be any span element containing the icon.

<button data-batch-action="true"
id="images__row_6dd12908-c3d9-4992-96f6-196966e23a8c__action_delete"
class="btn btn-default btn-danger" name="action" help_text="Deleted
images are not recoverable." type="submit"
value="images__delete__6dd12908-c3d9-4992-96f6-196966e23a8c"> Delete
Image </button>

This is in:
https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets
/action-list/actions-delete.template.html

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1526054

Title:
  Angular delete action icons and alignment wrong

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  
  Angular Table actions are using a different icon for delete than the django actions. In addition, the spacing and font is different.

  http://pasteboard.co/2c1hmge.png

  This is in:
  https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets
  /action-list/actions-delete-selected.template.html


  Angular row delete actions have an icon even though their django
  counterparts do not.

  On the Django table, there is not an icon for row actions. I did a
  screen grab below (note that I messed with the code to force it to
  only have delete actions).

  http://pasteboard.co/2c1hmge.png

  If you look at the rendered HTML on the Django table, there does not
  appear to be any span element containing the icon.

  <button data-batch-action="true"
  id="images__row_6dd12908-c3d9-4992-96f6-196966e23a8c__action_delete"
  class="btn btn-default btn-danger" name="action" help_text="Deleted
  images are not recoverable." type="submit"
  value="images__delete__6dd12908-c3d9-4992-96f6-196966e23a8c"> Delete
  Image </button>

  This is in:
  https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets
  /action-list/actions-delete.template.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1526054/+subscriptions