yahoo-eng-team team mailing list archive

[Hong Hui Xiao <xiaohhui@xxxxxxxxxx>]

Public bug reported:

Found this when reviewing code.

neutron/api/v2attribute.py may validate list of items, there are
different functions to validate list of different items. The code are
mostly duplicated in [1-3]. And more can be expected in future.



[1] https://github.com/openstack/neutron/blob/b8d281a303ca12440aebb55895ebb192d25cecf8/neutron/api/v2/attributes.py#L121
[2] https://github.com/openstack/neutron/blob/b8d281a303ca12440aebb55895ebb192d25cecf8/neutron/api/v2/attributes.py#L350
[3] https://github.com/openstack/neutron/blob/b8d281a303ca12440aebb55895ebb192d25cecf8/neutron/api/v2/attributes.py#L411

** Affects: neutron
     Importance: Undecided
     Assignee: Hong Hui Xiao (xiaohhui)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Hong Hui Xiao (xiaohhui)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1527113

Title:
  Code duplication in neutron/api/v2attribute.py

Status in neutron:
  New

Bug description:
  Found this when reviewing code.

  neutron/api/v2attribute.py may validate list of items, there are
  different functions to validate list of different items. The code are
  mostly duplicated in [1-3]. And more can be expected in future.




  [1] https://github.com/openstack/neutron/blob/b8d281a303ca12440aebb55895ebb192d25cecf8/neutron/api/v2/attributes.py#L121
  [2] https://github.com/openstack/neutron/blob/b8d281a303ca12440aebb55895ebb192d25cecf8/neutron/api/v2/attributes.py#L350
  [3] https://github.com/openstack/neutron/blob/b8d281a303ca12440aebb55895ebb192d25cecf8/neutron/api/v2/attributes.py#L411

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1527113/+subscriptions