← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1526162] Re: Add instance.save() when handling nova-compute failure during a soft reboot

 

Reviewed:  https://review.openstack.org/257692
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2ecb9f1e112c5f866e9b8fc2029c594c0b309c28
Submitter: Jenkins
Branch:    master

commit 2ecb9f1e112c5f866e9b8fc2029c594c0b309c28
Author: Kevin_Zheng <zhengzhenyu@xxxxxxxxxx>
Date:   Tue Dec 15 14:34:52 2015 +0800

    Add instance.save() when handling reboot in init instance
    
    We have added a logic to handle nova-compute failure during
    a soft reboot in patch: https://review.openstack.org/#/c/219980
    but we have missed to add instance.save() to save the
    modified task state, so the logic doesn't work.
    
    This patch adds instance.save() at the end of this handling.
    
    Change-Id: I0490643c5a1352ff13fd71d43be52260230f7df8
    Closes-Bug: #1526162


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1526162

Title:
  Add instance.save() when handling nova-compute failure during a soft
  reboot

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In patch https://review.openstack.org/#/c/219980 we added a few lines
  of code to handle nova-compute failure during a soft reboot.

  http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n1059 to 1067
  but somehow we missed instance.save() at the end of this logic, so the task state didn't
  saved and the logic doesn't work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1526162/+subscriptions


References