yahoo-eng-team team mailing list archive

[Mark McLoughlin <markmc@xxxxxxxxxx>]

Public bug reported:

It appears that https://review.openstack.org/256069 took the
signature_utils modules from Glance and modified it in fairly
superficial ways based on review feedback:

  $ diff -u nova/nova/signature_utils.py glance/glance/common/signature_utils.py  | diffstat
  signature_utils.py |  182 ++++++++++++++++++++++++-----------------------------
  1 file changed, 83 insertions(+), 99 deletions(-)

The Oslo project was created to avoid this sort of short-sighted cut-
and-pasting. This code should really be in a python library that both
Glance and Nova could use directly.

Perhaps the code could be moved to a new library in the Glance project,
or a new library in the Oslo project, or into the cryptography library
itself?

** Affects: glance
     Importance: Undecided
         Status: New

** Affects: nova
     Importance: Undecided
         Status: New

** Also affects: glance
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1528349

Title:
  Nova and Glance contain a near-identical signature_utils module

Status in Glance:
  New
Status in OpenStack Compute (nova):
  New

Bug description:
  It appears that https://review.openstack.org/256069 took the
  signature_utils modules from Glance and modified it in fairly
  superficial ways based on review feedback:

    $ diff -u nova/nova/signature_utils.py glance/glance/common/signature_utils.py  | diffstat
    signature_utils.py |  182 ++++++++++++++++++++++++-----------------------------
    1 file changed, 83 insertions(+), 99 deletions(-)

  The Oslo project was created to avoid this sort of short-sighted cut-
  and-pasting. This code should really be in a python library that both
  Glance and Nova could use directly.

  Perhaps the code could be moved to a new library in the Glance
  project, or a new library in the Oslo project, or into the
  cryptography library itself?

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1528349/+subscriptions