yahoo-eng-team team mailing list archive

[OpenStack Infra <1526698@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/261944
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=36a98817f5e856680d1912bb5ecc1d6e7c7e245b
Submitter: Jenkins
Branch:    master

commit 36a98817f5e856680d1912bb5ecc1d6e7c7e245b
Author: Tatiana Ovchinnikova <t.v.ovtchinnikova@xxxxxxxxx>
Date:   Mon Dec 28 12:16:35 2015 +0300

    Make it possible to pick False for default stack parameter value
    
    While creating Heat stack user has to set all required stack parameters.
    So if there is no default value for boolean type parameter, user has to
    choose between True or False. However the boolean field is marked as
    "required" and doesn't accept False value. This patch set removes
    requirement from this field and allows user to pick False for boolean
    parameter.
    
    Change-Id: Ie9495a8c83f33d6634931888b31336e5a1b52130
    Closes-Bug: #1526698


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1526698

Title:
  Can not create Heat stack with boolean parameter with False value

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In horizon in Orchestration panel I want to create Heat stack with
  template:   [pic1]

  heat_template_version: 2013-05-23
  parameters:
    bool_param:
      type: boolean

  After setting all necessary parameters I want to use bool_param with False value.
  But it raise error, that I should specify this parameter. [pic2]

  I understand, that workaround is to use default False for this
  parameter.

  However, I think, that it's a bug, because mentioned workaround does
  not apply for case, when I want to have parameter without default
  value. It may be necessary, when some important logic is used in
  template and I want to attract an attention of user to make a choice
  between False or True.

  Probably will be good to replace checkbox on some list with possible
  options.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1526698/+subscriptions