← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1512207] Re: Fix usage of assertions

 

Reviewed:  https://review.openstack.org/263561
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=06be50b97a28f490951ca44f9880be161a54ecc1
Submitter: Jenkins
Branch:    master

commit 06be50b97a28f490951ca44f9880be161a54ecc1
Author: yangyapeng <yang.yapeng@xxxxxxxxxxx>
Date:   Mon Jan 4 09:39:02 2016 -0500

    Use assertTrue/False instead of assertEqual(T/F)
    
    The usage of assertEqual(True/False, ***) should be changed
    to a meaningful format of assertTrue/False(***).
    
    Change-Id: I66110e5fc1afdf9dd6824b1f7bcb7b2c091a272d
    Closes-Bug: #1512207


** Changed in: python-novaclient
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1512207

Title:
  Fix usage of assertions

Status in Cinder:
  In Progress
Status in Glance:
  In Progress
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in Ironic:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  Fix Released
Status in neutron:
  In Progress
Status in python-novaclient:
  Fix Released
Status in Rally:
  New
Status in Sahara:
  Fix Released
Status in Stackalytics:
  In Progress
Status in OpenStack Object Storage (swift):
  In Progress

Bug description:
  Manila  should use the specific assertion:

    self.assertIsTrue/False(observed)

  instead of the generic assertion:

    self.assertEqual(True/False, observed)

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1512207/+subscriptions


References