← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1512207] Re: Fix usage of assertions

 

Reviewed:  https://review.openstack.org/264522
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=2612cab7b36dd38644a77f6ece5b59e8ae552cae
Submitter: Jenkins
Branch:    master

commit 2612cab7b36dd38644a77f6ece5b59e8ae552cae
Author: Kan <kansks@xxxxxxxxxx>
Date:   Thu Jan 7 02:41:48 2016 +0000

    Use assertTrue/False instead of assertEqual(T/F)
    
    The usage of assertEqual(True/False, ***) should be changed
    to a meaningful format of assertTrue/False(***)
    
    Change-Id: I0b20247ff52df5df552adc3daaaa3a0107cfb7fd
    Closes-Bug: #1512207


** Changed in: ironic-inspector
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1512207

Title:
  Fix usage of assertions

Status in Aodh:
  In Progress
Status in Barbican:
  In Progress
Status in Blazar:
  In Progress
Status in Cinder:
  In Progress
Status in Glance:
  In Progress
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in Ironic:
  In Progress
Status in Ironic Inspector:
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in Magnum:
  In Progress
Status in Manila:
  Fix Released
Status in neutron:
  Invalid
Status in oslo.utils:
  New
Status in python-novaclient:
  Fix Released
Status in Rally:
  New
Status in refstack:
  In Progress
Status in Sahara:
  Fix Released
Status in Solum:
  In Progress
Status in Stackalytics:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  Fix Released
Status in Vitrage:
  In Progress
Status in zaqar:
  Fix Released

Bug description:
  Manila  should use the specific assertion:

    self.assertIsTrue/False(observed)

  instead of the generic assertion:

    self.assertEqual(True/False, observed)

To manage notifications about this bug go to:
https://bugs.launchpad.net/aodh/+bug/1512207/+subscriptions


References