← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1531795] Re: locationProvider patch has broken Angular panels

 

Reviewed:  https://review.openstack.org/264702
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=aba0a44ebf5282549201112e7d2bb538420617b9
Submitter: Jenkins
Branch:    master

commit aba0a44ebf5282549201112e7d2bb538420617b9
Author: Rob Cresswell <rcresswe@xxxxxxxxx>
Date:   Thu Jan 7 10:39:33 2016 +0000

    Revert "LocationProvider should be set up on the Horizon App"
    
    This reverts commit 77656a8cb079935a8c4463da0c57c0bc034c7ce5.
    
    This change is incomplete, and appears to break all existing angular
    panels. Since that will effectively freeze development, we should
    revert the change until it is more complete.
    
    Change-Id: I047da7d7e508e2ef1b5323aa1950b265dba79640
    Closes-Bug: 1531795


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1531795

Title:
  locationProvider patch has broken Angular panels

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  "Error: [$location:nobase] $location in HTML5 mode requires a <base>
  tag to be present!"

  This error appears across multiple panels, including the new launch
  instance. To prevent development work stalling, we should revert it
  until the patch is more complete.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1531795/+subscriptions


References